Floating shadows for objects on incline

Report bugs found in the game, propose new feature requests, and discuss engine related content here.
samkod
Posts: 16
Joined: Mon Feb 25, 2019 9:52 pm

Floating shadows for objects on incline

Post by samkod »

A user reported this directly to me last week. It appears that objects on an incline appear off the ground and unrealistically float in the air. A perfect example of this is in blackmarsh in the the very first opening area of the game when you first obtain the sword and see the sheep.

2021-01-03 20-21-46-32.jpg
2021-01-03 20-21-46-32.jpg (210.49 KiB) Viewed 542 times
2021-01-03 20-21-40-41.jpg
2021-01-03 20-21-40-41.jpg (209.91 KiB) Viewed 542 times
2021-01-03 20-21-29-62.jpg
2021-01-03 20-21-29-62.jpg (177.98 KiB) Viewed 542 times
Shanjaq
Posts: 34
Joined: Wed Feb 27, 2019 11:03 am

Re: Floating shadows for objects on incline

Post by Shanjaq »

Thanks for creating the request, it looks like we'll need to borrow some code from Quake2 to get proper alias model shadows, here's what I could find relating to shadows from id:
https://github.com/id-Software/Quake-2/ ... esh.c#L306
Lethal
Posts: 6
Joined: Thu Feb 25, 2021 1:13 am

Re: Floating shadows for objects on incline

Post by Lethal »

Shanjaq wrote: Sat Jan 30, 2021 11:48 am Thanks for creating the request, it looks like we'll need to borrow some code from Quake2 to get proper alias model shadows, here's what I could find relating to shadows from id:
https://github.com/id-Software/Quake-2/ ... esh.c#L306
Hello,

It's been over a month since I reported this and just wanted to know if there was any update?

Thanks
Lethal
Posts: 6
Joined: Thu Feb 25, 2021 1:13 am

Re: Floating shadows for objects on incline

Post by Lethal »

Shanjaq wrote: Sat Jan 30, 2021 11:48 am Thanks for creating the request, it looks like we'll need to borrow some code from Quake2 to get proper alias model shadows, here's what I could find relating to shadows from id:
https://github.com/id-Software/Quake-2/ ... esh.c#L306
HELLO???????
samkod
Posts: 16
Joined: Mon Feb 25, 2019 9:52 pm

Re: Floating shadows for objects on incline

Post by samkod »

Just came across this: https://sourceforge.net/p/uhexen2/bugs/69/

Will examine the UQE source and see. This likely isn't going to be a quick fix.
Lethal
Posts: 6
Joined: Thu Feb 25, 2021 1:13 am

Re: Floating shadows for objects on incline

Post by Lethal »

samkod wrote: Thu Mar 18, 2021 12:25 pm Just came across this: https://sourceforge.net/p/uhexen2/bugs/69/

Will examine the UQE source and see. This likely isn't going to be a quick fix.
Hello,

Any update on this?
samkod
Posts: 16
Joined: Mon Feb 25, 2019 9:52 pm

Re: Floating shadows for objects on incline

Post by samkod »

No, this is not going to be a simple fix and is considered low priority at this point. In fact this is really considered a new feature since none of the old shadow code will be used. Hexen II contributors in our community generally determine criticality of bugs. Feel free to contribute to our code or start a conversation in discord with our contributors about reaching a solution.
Lethal
Posts: 6
Joined: Thu Feb 25, 2021 1:13 am

Re: Floating shadows for objects on incline

Post by Lethal »

samkod wrote: Fri Apr 30, 2021 12:08 pm No, this is not going to be a simple fix and is considered low priority at this point. In fact this is really considered a new feature since none of the old shadow code will be used. Hexen II contributors in our community generally determine criticality of bugs. Feel free to contribute to our code or start a conversation in discord with our contributors about reaching a solution.
How can it be considered a "new feature" when it's already present in the source port albeit poorly with bugs?

A "new feature" by definition would be something never before implimented.
samkod
Posts: 16
Joined: Mon Feb 25, 2019 9:52 pm

Re: Floating shadows for objects on incline

Post by samkod »

It's considered a new feature because the current shadow code has limitations that will not perform the desired outcome and will require rewriting the shadow code to work with this source port.
Lethal
Posts: 6
Joined: Thu Feb 25, 2021 1:13 am

Re: Floating shadows for objects on incline

Post by Lethal »

samkod wrote: Fri May 07, 2021 6:46 pm It's considered a new feature because the current shadow code has limitations that will not perform the desired outcome and will require rewriting the shadow code to work with this source port.
So logically an update to an already existing feature so that it works as intended rather than the broken mess it is now.
Locked